This article does a good job of explaining what Michael Cohen does for Donald Trump. What the article does not do is explain how dangerous this is. This is right out of the organized crime playbook, but instead he is the president. That is having a lawyer who is not doing any legal work, but instead just uses his degree as a way to try and keep some information privileged. The courts have not been kind to this in the past, but Michael Cohen and Donald Trump are still living in 1970s New York.
Also it's really something that we have people in 2018 that look at Roy Cohn as some kind of heroic figure. That said Nathan Lane will be playing him on Broadway starting in late March in "Angels in America: Millennium Approaches" and I am 100% interested in seeing it!